Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7 feature user authentication and authorization #21

Merged
merged 13 commits into from
Nov 12, 2024
Merged

7 feature user authentication and authorization #21

merged 13 commits into from
Nov 12, 2024

Conversation

RespectMathias
Copy link
Contributor

✨ Description

Microsoft Identity added using scaffold and customized to project needs.

Linked Issue: #7

🔄 Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 🔧 Improvement

✅ Checklist

  • 📝 Code follows project style guidelines
  • 🔗 Relevant issue is linked and moved to 'In Progress'
  • 🧪 All relevant tests have been added or updated
  • ✔️ Continuous integration (CI) tests have passed
  • 👀 Ready for review

📄 Additional Information

Also tests have been added and passed. Didn't deem it necessary to test all the code as most is from the scaffold.

@RespectMathias
Adding MS Identity
6c5dc73 
Added:
* Login Partial
* Microsoft Identity package
@RespectMathias
Functional login and registration
90ac711
@RespectMathias
Customize Identity
dddec59 
Added:
* Identity pages, will move them later and use custom versions
@RespectMathias
Version Update
27a7bac
@RespectMathias
Custom Account pages
a59c313 
Pages moved to Pages folder for custom implementation, instead of overriding.

Updated layout and Login
@RespectMathias
Update Register.cshtml
ca5739f
@RespectMathias
Using Custom
928987e 
Fixing namespace and making sure to use the custom ones in Account
@RespectMathias
clean
ff9fb13
@RespectMathias
Models
45b1ec5 
Added:
* Role Model
* User Model
@RespectMathias
Implement custom User and roles
6320931 
Re-did scaffolding but this time using the custom user and roles
@RespectMathias
Adding Roles
dcdcf3c 
Roles Added:
* Admin
@RespectMathias
Tests added
40eadec 
Added:
* Login Tests
@RespectMathias
Additional tests
d756fd6
@RespectMathias RespectMathias linked an issue Nov 12, 2024 that may be closed by this pull request
[Feature] - User Authentication and Authorization #7
Closed
5 tasks
@RespectMathias RespectMathias requested review from Ahmad-Alqadiri and GiGwebs and removed request for Ahmad-Alqadiri November 12, 2024 00:07
GiGwebs
GiGwebs approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@GiGwebs GiGwebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats quite a lot but I accept with lots of hope

@GiGwebs GiGwebs merged commit 378df8f into main Nov 12, 2024
1 check passed
@GiGwebs GiGwebs deleted the 7-feature-user-authentication-and-authorization branch November 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiGwebs GiGwebs GiGwebs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] - User Authentication and Authorization
2 participants
@RespectMathias @GiGwebs