Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallowing constructing rowset from a session #1082

Closed
wants to merge 2 commits into from
Closed

Disallowing constructing rowset from a session #1082

wants to merge 2 commits into from

Conversation

cstiborg
Copy link
Contributor

@cstiborg cstiborg commented Oct 9, 2023

After discussion on #1081 it was decided to explicitly disallow the implicit constructor rowset(soci::session const & session).

vadz pushed a commit that referenced this pull request Oct 11, 2023
@cstiborg @vadz
Disallow constructing rowset from a session
2e4b44b 
This doesn't make sense, so explicitly delete the ctor from session to
prevent such code from compiling.

Closes #1081.

See #1082.
@vadz
Copy link
Member

vadz commented Oct 11, 2023

Thanks, I've cherry picked the second commit (please don't include merges in the branches from which you make the PRs, you should branch them directly from SOCI master) with just some comments added.

@vadz vadz closed this Oct 11, 2023
cstiborg added a commit to cstiborg/soci that referenced this pull request Oct 11, 2023
@cstiborg
Disallow constructing rowset from a session
87d6ff6 
This doesn't make sense, so explicitly delete the ctor from session to
prevent such code from compiling.

Closes SOCI#1081.

See SOCI#1082.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cstiborg @vadz