Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency version #96

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Update dependency version #96

merged 5 commits into from
Apr 8, 2024

Conversation

justinvasel
Copy link
Contributor

@justinvasel justinvasel commented Feb 8, 2024

PR to accompany Issue #91

  • Drop support for python versions less than 3.11
  • Upgrade hop-client from v0.8.0 to v0.9.0
  • Drop several dependencies that don't appear to be used
  • Upgrade all packages that can be upgraded
  • All tests in the suite are passing on my local machine

Resolves: #91, #78

- Drop support for python versions less than 3.11
- Drop several dependencies that don't appear to be used
- Upgrade all packages that can be upgraded.
@justinvasel
Copy link
Contributor Author

Following the merger of this PR, I recommend tagging a new release, so that snews_cs can pull in the latest version and upgrade its own dependencies.

@justinvasel
Copy link
Contributor Author

Apologies for the email traffic... I had to do a bunch of tests to get the github workflow working with the new versions of hop-client and pytest. I ultimately ended up squashing all those commits and resubmitting the PR to keep the commit history clean. Probably can't say the same for your inbox though... :/

@KaraMelih
Copy link
Collaborator

I think I was able to follow the flow. I can try to test this branch on my local machine next Monday

@KaraMelih
Copy link
Collaborator

Hi, I could only get back to these PRs now.
I checked the existing PRs addressing the SQL fixes and datetime conversions.
Now, these branches #90 and SNEWS2/SNEWS_Coincidence_System#83 should play nicely with each other. While they should in principle not affect this PR, in order for me to run updated dependencies I need working versions of the scripts.

@KaraMelih KaraMelih merged commit 9526f96 into main Apr 8, 2024
2 checks passed
@KaraMelih KaraMelih deleted the update-dependency-version branch May 10, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning Up Project Dependencies
2 participants