SQL Database Compatibility #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reintroduce meta field add is_test to accepted fields
|
Oops. The test scripts need to be adjusted. Converting this to a draft pull request. |
KaraMelih
commented
Dec 12, 2023
KaraMelih
added a commit
that referenced
this pull request
Dec 19, 2023
Merge pull request #84 from SNEWS2/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we got rid of the
metafield where we used to group all unknown key-value pairs. Instead we were now adding them as new key-value pairs to the dictionary.However, with the new SQL backed, this seemed more complicated to track. So, I rolled back to the original idea.
If the user builds a message that contains some key-value pairs "that do not belong to ANY of the created tiers" they are shipped under the
"meta"key in the message. These meta keys are NOT displayed in the alert messages but they are there for long-term storage and additional investigation, e.g. any comment the user might have, or any additional data that they might provide for triangulation etc. Coincidence System (snews cs) does not try to investigate the data send under the meta.Along with this addition, I also
is_testan accepted argument for each tier, defaulted it to False when nothing is passed