-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing logic #120
Testing logic #120
Conversation
Disabled MacOS 12 (Monterrey) and 13 (Ventura) in the buildbot. Technically we should figure out how to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll make a separate ticket to check compatibility with Mac OS 13 (Ventura).
Once the snews_cs branch; https://github.com/SNEWS2/SNEWS_Coincidence_System/tree/internal_testing_logic
is merged, there will be 2 caches running in parallel and no need to change topics for testing. The testing and actual production can co-exists with this logic.
The changes made in this PR allows for the
is_test
argument in several places. When passed, the outgoing messages are sent for this 2nd (test) cache, and subscribed channels are also for the test alert topic.