Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal testing logic #124

Closed
wants to merge 20 commits into from
Closed

Internal testing logic #124

wants to merge 20 commits into from

Conversation

KaraMelih
Copy link
Collaborator

I added a second cache called test_coinc_cache and a second alert publisher which is set to publish alerts to the "test connection topic" and not the main alert topic.

Except for long term storage both instances and publications are doing the same things.

Once a message in the stream is read. The contents are first searched by the command handler, which returns True if the message is indeed a coincidence tier message. (if not, check if it is a known command, or significance tier or etc. and returns False)

The new part starts here. If the message is sent with a is_test=True flag, coincidence decider starts using the test cache and runs the coincidence search with this cache. The main cache still remains but it is not used at this time.
If a coincidence is found for this test cache, then it calls the alert publisher which publishes the alerts to the test connection topic.

@KaraMelih KaraMelih requested a review from sybenzvi August 15, 2024 20:12
@KaraMelih
Copy link
Collaborator Author

snews_pt should also be adjusted to subscribe to this topic to expect test alerts.

@KaraMelih KaraMelih marked this pull request as draft August 15, 2024 20:41
@KaraMelih KaraMelih closed this Aug 15, 2024
@KaraMelih
Copy link
Collaborator Author

On the PT side, it should work together with this branch

https://github.com/SNEWS2/SNEWS_Publishing_Tools/tree/testing_logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant