-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal testing logic #124
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snews_pt should also be adjusted to subscribe to this topic to expect test alerts. |
On the PT side, it should work together with this branch https://github.com/SNEWS2/SNEWS_Publishing_Tools/tree/testing_logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a second cache called
test_coinc_cache
and a second alert publisher which is set to publish alerts to the "test connection topic" and not the main alert topic.Except for long term storage both instances and publications are doing the same things.
Once a message in the stream is read. The contents are first searched by the command handler, which returns True if the message is indeed a coincidence tier message. (if not, check if it is a known command, or significance tier or etc. and returns False)
The new part starts here. If the message is sent with a
is_test=True
flag, coincidence decider starts using the test cache and runs the coincidence search with this cache. The main cache still remains but it is not used at this time.If a coincidence is found for this test cache, then it calls the alert publisher which publishes the alerts to the test connection topic.