Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unit tests. #120

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Add new unit tests. #120

merged 12 commits into from
Aug 16, 2024

Conversation

sybenzvi
Copy link
Contributor

Added a test of the snews_pt connection to the server.

@sybenzvi sybenzvi requested a review from KaraMelih August 15, 2024 15:16
@KaraMelih KaraMelih marked this pull request as draft August 15, 2024 16:37
@KaraMelih
Copy link
Collaborator

SNEWS_test_logic

This is the logic that I am going for.

Right now we have the

  • red line connections (observation messages from snews_pt, coincidence search in snews_cs, and alert back to user via snews_pt)
  • green line connections (snews_pt testing connection, snews_cs receiving and sending a confirmation, snews_pt reading it back)

We need to implement the blue line connections for the tests. This flow ensures that the coincidence instance is up and running on snews_cs and does not mess with the main alert feed (red line)

@KaraMelih
Copy link
Collaborator

SNEWS_test_logic_horizontal

@sybenzvi sybenzvi merged commit 1d893bd into main Aug 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants