Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FareClassEnumeration in principle is defined twice. Should be harmonised (and there is a typo in "secondClass " #109

Open
ue71603 opened this issue Apr 14, 2023 · 0 comments

Comments

@ue71603
Copy link
Collaborator

ue71603 commented Apr 14, 2023

Summary of search parameters:
Searching for the string: "secondClass", case sensitive
Files: "C:\Users\ue71603\MG_Daten\github\OJP4", including subfolders
C:\Users\ue71603\MG_Daten\github\OJP4\examples\functions\trip\TR_05_response_with_occupation.xml
(Ln 90, Char 27) siri:FareClasssecondClass </siri:FareClass>
C:\Users\ue71603\MG_Daten\github\OJP4\siri\xsd\siri_model\siri_facilities.xsd
(Ln 227, Char 28) <xsd:enumeration value="secondClass"/>
C:\Users\ue71603\MG_Daten\github\OJP4\siri\xsd\siri_model\siri_journey_support.xsd
(Ln 957, Char 28) <xsd:enumeration value="secondClass ">

siri_facilities
<xsd:simpleType name="FareClassFacilityEnumeration"> <xsd:annotation> <xsd:documentation>Values for FareClass Facility: TPEG pti_table 23.</xsd:documentation> </xsd:annotation> <xsd:restriction base="xsd:NMTOKEN"> <xsd:enumeration value="unknown"/> <xsd:enumeration value="pti23_0"/> <xsd:enumeration value="unknown"/> <xsd:enumeration value="pti23_6"/> <xsd:enumeration value="firstClass"/> <xsd:enumeration value="pti23_7"/> <xsd:enumeration value="secondClass"/> <xsd:enumeration value="pti23_8"/> <xsd:enumeration value="thirdClass"/> <xsd:enumeration value="pti23_9"/> <xsd:enumeration value="economyClass"/> <xsd:enumeration value="pti23_10"/> <xsd:enumeration value="businessClass"/> </xsd:restriction> </xsd:simpleType>

journey_support:
<xsd:simpleType name="FareClassEnumeration"> <xsd:annotation> <xsd:documentation>Values for Fare Class Facility. (since SIRI 2.1)</xsd:documentation> </xsd:annotation> <xsd:restriction base="xsd:NMTOKEN"> <xsd:enumeration value="unknown"> <xsd:annotation> <xsd:documentation>pti23_0</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="firstClass"> <xsd:annotation> <xsd:documentation>pti23_6</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="secondClass "> <xsd:annotation> <xsd:documentation>pti23_7</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="thirdClass"> <xsd:annotation> <xsd:documentation>pti23_8</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="preferente"/> <xsd:enumeration value="premiumClass"> <xsd:annotation> <xsd:documentation>pti23_6_1</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="businessClass"> <xsd:annotation> <xsd:documentation>Business Class - pti23_10</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="standardClass"> <xsd:annotation> <xsd:documentation>Standard class Add pti23_7</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="turista"/> <xsd:enumeration value="economyClass"> <xsd:annotation> <xsd:documentation>pti23_9</xsd:documentation> </xsd:annotation> </xsd:enumeration> <xsd:enumeration value="any"/> </xsd:restriction> </xsd:simpleType>

And the typo (additional blank):
C:\Users\ue71603\MG_Daten\github\OJP4\siri\xsd\siri_model\siri_journey_support.xsd
(Ln 957, Char 28) <xsd:enumeration value="secondClass "> <-- blank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant