Add type definitions for bottleneck/light #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, octokit/plugin-retry.js uses
bottleneck/light
for ratelimiting, but there's a little bit of trouble importing types when usingbottleneck/light
over the mainbottleneck
import.I did some testing and adding a
light.d.ts
definition file with existing namespace and class types but under abottleneck/light
module lets typescript find the types for the light import.I noticed that the existing type definitions were using EJS templates, so I move the namespace and class type definitions to a shared EJS template and included that in both the bottleneck.d.ts.ejs and light.d.ts.ejs template files.
This fixes the issue in octokit/plugin-retry.js#110, but I'm open to suggestions if there's a better way to do this!