Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy data #69

Open
wants to merge 2 commits into
base: jabmap
Choose a base branch
from
Open

Add dummy data #69

wants to merge 2 commits into from

Conversation

rmoradc
Copy link
Collaborator

@rmoradc rmoradc commented Sep 23, 2020

Dummy data can be found in jabref/JabMapTestData

Implements #62

Dummy data can be found in jabref/JabMapTestData.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Dummy data can be found in jabref/JabMapTestData
Copy link
Collaborator

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the data required by the frontend team NOW. This data is older than the current code (#61) produces.

@@ -0,0 +1,63 @@
% Encoding: UTF-8
@INPROCEEDINGS{aPaper,
author={T. {Kim} and S. {Park} and T. {Lee}},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to a add braces around last names (in case they consists of single words)

booktitle={2017 IEEE International Symposium on Software Reliability Engineering Workshops (ISSREW)},
title={Applying software reliability engineering process to software development in Korea defense industry},
year={2017},
volume={},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leave empty fields out (should work withthe frontend nevertheless)

id = {2},
name = {test number 2},
bibEntry = {aPaper},
icons = {read,low_priority},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snake_case is OK for me. Maybe we need to write an ADR on that. (camel case, snake case, separataion by spaces

id = {2},
name = {test number 2},
bibEntry = {aPaper},
icons = {read,low_priority},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better readability, I would suggest spaces to separate keywords

Suggested change
icons = {read,low_priority},
icons = {read, low_priority},

id = {3},
name = {test number 3},
bibEntry = {aPaper},
icons = {read,high_priority},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
icons = {read,high_priority},
icons = {read, high_priority},

}

@MindMapNode{3,
id = {3},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this really is work-in-progress - we discussed to remove id (as this is the BibTeX key)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was unaware of the changes to the fields at the time. Data has now been updated to the current version.


@MindMapNode{3,
id = {3},
name = {test number 3},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New version: label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants