APS: duplicated affids removal #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drjova
reviewed
Dec 6, 2023
tests/test_aps.py
Outdated
| @@ -13,9 +13,11 @@ | |||
|
|
|||
| from scrapy.http import TextResponse | |||
| from hepcrawl.spiders import aps_spider | |||
| from hepcrawl.parsers import aps_apr | |||
There was a problem hiding this comment.
A mistake, removed!
ErnestaP
force-pushed
the
APS-duplicate
branch
from
9dd8cde to
666c8bf
Compare
drjova
approved these changes
Dec 6, 2023
ErnestaP
force-pushed
the
APS-duplicate
branch
2 times, most recently
from
8ebb7fa to
2005e8b
Compare
drjova
reviewed
Dec 7, 2023
tests/test_aps.py
Outdated
| 'surname': u'Sethna'}] | ||
|
|
||
| sorted_expected_results = sorted( | ||
| expected_results, key=lambda x: x['affiliations'][0]['value'] if x['affiliations'] else '') |
There was a problem hiding this comment.
@ErnestaP why do we have to sort the ‘expected_results’? Lists are maintaining the order, that means we just need to put the data in the correct order.
ErnestaP
force-pushed
the
APS-duplicate
branch
2 times, most recently
from
1a3c401 to
fb91246
Compare
ErnestaP
force-pushed
the
APS-duplicate
branch
from
fb91246 to
c41f697
Compare
drjova
reviewed
Dec 7, 2023
| @@ -64,6 +64,7 @@ | |||
| { | |||
| "surname":"Alemi", | |||
| "affiliationIds":[ | |||
| "a1", | |||
There was a problem hiding this comment.
So, at the end we are not testing this anywhere, right? So no need to change it
There was a problem hiding this comment.
we are testing it, we see that parsed author does not have repetitive affiliations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.