fix apikey auth middleware (#41)

SAREhub · Dec 10, 2019 · 0a9382b · 0a9382b
1 parent 7f70b77
commit 0a9382b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/SAREhub/Microt/App/Auth/ApiKey/ApiKeyAuthMiddleware.php b/src/SAREhub/Microt/App/Auth/ApiKey/ApiKeyAuthMiddleware.php
@@ -34,7 +34,8 @@ public function __invoke(Request $request, Response $response, callable $next)
         if ($request->getQueryParam(self::QP_APIKEY, "") !== $this->apiKey) {
             return JsonResponse::wrap($response)->error("Invalid apiKey", [], 401);
         }
-        $next($request, $response);
+
+        return $next($request, $response);
     }
 
 

diff --git a/tests/unit/SAREhub/Microt/App/Auth/ApiKey/ApiKeyAuthMiddlewareTest.php b/tests/unit/SAREhub/Microt/App/Auth/ApiKey/ApiKeyAuthMiddlewareTest.php
@@ -32,9 +32,11 @@ public function testInvokeWhenPassed()
         $response = HttpHelper::response();
         $next = CallableMock::create();
 
-        $next->expects("__invoke")->with($request, $response);
+        $expectedResponse = HttpHelper::response();
+        $next->expects("__invoke")->with($request, $response)->andReturn($expectedResponse);
 
-        ($this->middleware)($request, $response, $next);
+        $currentResponse = ($this->middleware)($request, $response, $next);
+        $this->assertSame($expectedResponse, $currentResponse);
     }
 
     public function testInvokeWhenNotPassed()