Skip to content

Commit

Permalink
add hooks for rule group chanages (#13)
Browse files Browse the repository at this point in the history
  • Loading branch information
Mararok authored Aug 21, 2020
1 parent ef57747 commit 9bd5acf
Show file tree
Hide file tree
Showing 4 changed files with 77 additions and 1 deletion.
12 changes: 12 additions & 0 deletions src/SAREhub/EasyECA/Rule/AddRuleGroupListener.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php


namespace SAREhub\EasyECA\Rule;


use SAREhub\EasyECA\Rule\Definition\EventRuleGroupDefinition;

interface AddRuleGroupListener
{
public function onAddRuleGroup(EventRuleGroupDefinition $definition): void;
}
27 changes: 27 additions & 0 deletions src/SAREhub/EasyECA/Rule/EventRuleGroupManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ class EventRuleGroupManager
*/
private $groupParser;

/**
* @var AddRuleGroupListener
*/
private $addGroupListener;

/**
* @var RemoveGroupFromAllEventsListener
*/
private $removeGroupFromAllEventsListener;

public function __construct(MulticastGroupsRouter $router, RuleGroupParser $groupParser)
{
$this->router = $router;
Expand All @@ -28,10 +38,27 @@ public function add(EventRuleGroupDefinition $definition): void
{
$ruleGroup = $definition->getRuleGroup();
$this->router->add($definition->getEventType(), $ruleGroup->getId(), $this->groupParser->parse($ruleGroup));

if ($this->addGroupListener) {
$this->addGroupListener->onAddRuleGroup($definition);
}
}

public function removeGroupFromAllEvents(string $groupId): void
{
$this->router->removeFromAll($groupId);
if ($this->removeGroupFromAllEventsListener) {
$this->removeGroupFromAllEventsListener->onRemoveGroupFromAllEvents($groupId);
}
}

public function setAddRuleGroupListener(AddRuleGroupListener $listener): void
{
$this->addGroupListener = $listener;
}

public function setRemoveRuleGroupListener(RemoveGroupFromAllEventsListener $listener): void
{
$this->removeGroupFromAllEventsListener = $listener;
}
}
10 changes: 10 additions & 0 deletions src/SAREhub/EasyECA/Rule/RemoveGroupFromAllEventsListener.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php


namespace SAREhub\EasyECA\Rule;


interface RemoveGroupFromAllEventsListener
{
public function onRemoveGroupFromAllEvents(string $groupId): void;
}
29 changes: 28 additions & 1 deletion tests/unit/SAREhub/EasyECA/Rule/EventRuleGroupManagerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,34 @@ public function testRemoveFromAll(): void
{
$ruleGroupId = "test_group_id";

$this->router->expects("removeFromAll")->withArgs(["test_group_id"]);
$this->router->expects("removeFromAll")->with("test_group_id");

$this->manager->removeGroupFromAllEvents($ruleGroupId);
}

public function testAddGroupWhenHasListener()
{
$ruleGroup = $this->createRuleGroup("test_group_id");
$definition = new EventRuleGroupDefinition("test_event_type", $ruleGroup);
$this->groupParser->allows("parse")->andReturn($this->createProcessor());
$this->router->allows("add");
$listener = \Mockery::mock(AddRuleGroupListener::class);
$this->manager->setAddRuleGroupListener($listener);

$listener->expects("onAddRuleGroup")->with($definition);

$this->manager->add($definition);

}

public function testRemoveFromAllWhenHasListener(): void
{
$ruleGroupId = "test_group_id";
$this->router->allows("removeFromAll");
$listener = \Mockery::mock(RemoveGroupFromAllEventsListener::class);
$this->manager->setRemoveRuleGroupListener($listener);

$listener->expects("onRemoveGroupFromAllEvents")->with($ruleGroupId);

$this->manager->removeGroupFromAllEvents($ruleGroupId);
}
Expand Down

0 comments on commit 9bd5acf

Please sign in to comment.