Scimono jakarta branch next dev #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word "Default" in the "DefaultSchemasCallback.java" let me assume that I can derive classes from it to implement some method which are needed in my use case. The fact that getAttribute is overridden in the DefaultSchemasCallback.java leads to confusion and makes it even harder to make it work with a derived class. I think it is better to just let the default method in the interface shining through. Co-authored-by: Hristo Borisov <[email protected]> (cherry picked from commit 81fd5ff)
I think there are some deps which are only needed in test context. Co-authored-by: Hristo Borisov <[email protected]> (cherry picked from commit d2d2f61)
The custom schema is not only accepting custom schemas, it is accepting any syntactic valid schema. That's why [these lines](https://github.com/SAP/scimono/blob/adebc03c26dbda55366849a477b4bcfb26e574e2/scimono-server/src/main/java/com/sap/scimono/callback/schemas/SchemasCallback.java#L37-L44) are effecting that every syntactic valid schema is handled like a custom schema. Core schemas will not be found. In my understanding the core schemas are not custom schemas. --------- Co-authored-by: Hristo Borisov <[email protected]> (cherry picked from commit 5fcbc9a)
parvandobrev
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.