Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap.m.SelectDialog: Allow clear in single selection mode #2380

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zypA13510
Copy link
Contributor

@zypA13510 zypA13510 commented Jan 17, 2019

The clear button will always be enabled, if showClearButton=true and multiSelect=false.
The clear button behavior is redefined to act as clear+confirm in single selection mode.

This closes #2379. This will provide a workaround for #898.

P.S. I'm not sure if this should count as a [FIX] or a [FEATURE], so it's not included in any title.

@stoyanovski
Copy link
Contributor

stoyanovski commented Jan 28, 2019

Hi @zypA13510,

Thank you for your contribution. I created internal incident regarding your pull-request. The colleagues from the corresponding team will check if it's relevant for their control.

Best Regards,
Oliver

@niyap
Copy link
Contributor

niyap commented Jan 30, 2019

Hello @zypA13510 ,

As is described in your related incident: #2379
We will analyze and evaluate all possible interactions and then we will make the decision.

Thank you for your contribution. Your proposal(pull request) will be evaluated as well.
We will keep you in touch regarding the progress and our final decision.
For this reason, we are currently not able to approve your pull request.

Thanks again for your proactivity and contribution!

Regards,
Niya

@zypA13510
Copy link
Contributor Author

Actually, this was submitted prior to the reply in 2379 (but probably not being tracked for some reasons?)

@Shtilianova
Copy link
Contributor

Internal record is 1980259563. The status of the issue will be updated here in GitHub.

The clear button is always enabled now, if showClearButton=true and multiSelect=false.
The clear button behavior is redefined to act as clear+confirm in single selection mode.
@CLAassistant
Copy link

CLAassistant commented Aug 5, 2020

CLA assistant check
All committers have signed the CLA.

@flovogt
Copy link
Member

flovogt commented Jun 15, 2023

This PR will be covered in backlog item FIORIDESIGN-614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sap.m.SelectDialog clear/confirm button should be enabled in single selection mode
6 participants