-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap.m.SelectDialog: Allow clear in single selection mode #2380
base: master
Are you sure you want to change the base?
Conversation
Hi @zypA13510, Thank you for your contribution. I created internal incident regarding your pull-request. The colleagues from the corresponding team will check if it's relevant for their control. Best Regards, |
Hello @zypA13510 , As is described in your related incident: #2379 Thank you for your contribution. Your proposal(pull request) will be evaluated as well. Thanks again for your proactivity and contribution! Regards, |
Actually, this was submitted prior to the reply in 2379 (but probably not being tracked for some reasons?) |
Internal record is 1980259563. The status of the issue will be updated here in GitHub. |
6ebcb1b
to
59fcc75
Compare
The clear button is always enabled now, if showClearButton=true and multiSelect=false. The clear button behavior is redefined to act as clear+confirm in single selection mode.
59fcc75
to
beb5668
Compare
This PR will be covered in backlog item FIORIDESIGN-614 |
The clear button will always be enabled, if
showClearButton=true
andmultiSelect=false
.The clear button behavior is redefined to act as clear+confirm in single selection mode.
This closes #2379. This will provide a workaround for #898.
P.S. I'm not sure if this should count as a [FIX] or a [FEATURE], so it's not included in any title.