Skip to content

SPIKE: IE11 handling

Jenna Badanowski edited this page Apr 29, 2019 · 7 revisions

What CSS is currently being used in fundamental that is not supported by IE11

Current Handling

https://github.com/SAP/fundamental/blob/master/scss/all-ie11.scss#L2 https://github.com/SAP/fundamental/blob/master/scss/components/popover.scss#L45

 @if $fd-support-css-var-fallback {
    box-shadow: 0 5px 20px 0 fd-color("neutral", 3), 0 2px 8px 0 fd-color("neutral", 2);
 }
 box-shadow: 0 5px 20px 0 var(--fd-color-neutral-3), 0 2px 8px 0 var(--fd-color-neutral-2);

results in fiori-fundamentals.css and fiori-fundamentals-ie11.css

Changes Needed

How are other well developed libraries handling ie11? material ui? bootstrap?

  • materialui, bootstrap not using CSS variables

PostCSS config changes

'postcss-simple-vars': {
            unknown: function (node, name, result) {
                node.warn(result, 'Unknown variable ' + name);
            },
            keep: true
        },
'postcss-css-variables': {
    preserve: true
 },

Steps needed

  • remove unneeded $fd-support-css-var-fallback from SCSS files
  • remove fundamentals-ie11 files
  • many missing colors need to be updated:
  • change npm run style:compile command, use node-sass inside of postcss as plugin after some things are done
  • run customscript.js through babel, or rewrite to ES5

Jekyll: handling IE11

  • find libraries for browser detection
  • for now- replacing with ie11 fundamental-css

How to advise consumers to handle IE11