Skip to content

Commit

Permalink
refactor: cleanup package.json scripts
Browse files Browse the repository at this point in the history
Signed-off-by: Jérôme Benoit <[email protected]>
  • Loading branch information
Jérôme Benoit committed Sep 29, 2023
1 parent 5226ae7 commit cd49fae
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 14 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ jobs:
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- name: Dependency Review
if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
uses: actions/dependency-review-action@v3
with:
base-ref: ${{ github.ref_name }}
head-ref: ${{ github.sha }}
- name: Pull Request Dependency Review
if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
uses: actions/dependency-review-action@v3
- uses: pnpm/action-setup@v2
with:
Expand All @@ -53,17 +53,17 @@ jobs:
- name: pnpm install
run: pnpm install --ignore-scripts
- name: pnpm lint
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
run: pnpm lint
- name: pnpm build
run: pnpm build
- name: pnpm test
run: pnpm test
- name: pnpm coverage
if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
run: pnpm coverage
- name: SonarCloud Scan
if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
uses: sonarsource/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -84,13 +84,13 @@ jobs:
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
- name: Dependency Review
if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
uses: actions/dependency-review-action@v3
with:
base-ref: ${{ github.ref_name }}
head-ref: ${{ github.sha }}
- name: Pull Request Dependency Review
if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ github.event_name == 'pull_request' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
uses: actions/dependency-review-action@v3
- uses: pnpm/action-setup@v2
with:
Expand All @@ -103,17 +103,17 @@ jobs:
- name: pnpm install
run: pnpm install --ignore-scripts
- name: pnpm lint
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
run: pnpm lint
- name: pnpm build
run: pnpm build
- name: pnpm test
run: pnpm test
- name: pnpm coverage
if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
run: pnpm coverage
- name: SonarCloud Scan
if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '18.x' }}
if: ${{ needs.check-secrets.outputs.sonar-token-exists == 'true' && github.repository == 'sap/e-mobility-charging-stations-simulator' && matrix.os == 'ubuntu-latest' && matrix.node == '20.x' }}
uses: sonarsource/[email protected]
with:
projectBaseDir: ui/web
Expand Down
4 changes: 0 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@
"coverage": "c8 report --reporter=lcov",
"coverage:html": "c8 report --reporter=html",
"clinic:clean": "clinic clean",
"git:sinit": "git submodule update --init --recursive --force",
"git:sdiff": "git diff && git submodule foreach 'git diff'",
"git:supdate": "git submodule update --remote --recursive --merge",
"git:spush": "git push --recurse-submodules=on-demand",
"release": "release-it"
},
"pnpm": {
Expand Down

0 comments on commit cd49fae

Please sign in to comment.