fix(simulator): handle close to zero duration formatting

Signed-off-by: Jérôme Benoit <[email protected]>
SAP · Nov 8, 2023 · 17b07e4 · 17b07e4
1 parent b3b3f0e
commit 17b07e4
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 20 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/utils/Utils.ts b/src/utils/Utils.ts
@@ -37,6 +37,9 @@ export const sleep = async (milliSeconds: number): Promise<NodeJS.Timeout> => {
 
 export const formatDurationMilliSeconds = (duration: number): string => {
   duration = convertToInt(duration);
+  if (duration < 0) {
+    throw new RangeError('Duration cannot be negative');
+  }
   const days = Math.floor(duration / (24 * 3600 * 1000));
   const hours = Math.floor(millisecondsToHours(duration) - days * 24);
   const minutes = Math.floor(
@@ -48,12 +51,15 @@ export const formatDurationMilliSeconds = (duration: number): string => {
       hoursToSeconds(hours) -
       minutesToSeconds(minutes),
   );
-  return formatDuration({
-    days,
-    hours,
-    minutes,
-    seconds,
-  });
+  return formatDuration(
+    {
+      days,
+      hours,
+      minutes,
+      seconds,
+    },
+    { zero: true },
+  );
 };
 
 export const formatDurationSeconds = (duration: number): string => {

diff --git a/ui/web/package.json b/ui/web/package.json
@@ -42,7 +42,7 @@
     "@types/node": "^20.9.0",
     "@typescript-eslint/eslint-plugin": "^6.10.0",
     "@typescript-eslint/parser": "^6.10.0",
-    "@vitejs/plugin-vue": "^4.4.0",
+    "@vitejs/plugin-vue": "^4.4.1",
     "@vitejs/plugin-vue-jsx": "^3.0.2",
     "@vitest/coverage-v8": "^0.34.6",
     "@vue/eslint-config-prettier": "^8.0.0",

diff --git a/ui/web/pnpm-lock.yaml b/ui/web/pnpm-lock.yaml