Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as.karpov1 Week 1,2,3 #40

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

karpovas1505
Copy link

Hi @nicogeburek
It is my results

@cla-assistant
Copy link

cla-assistant bot commented Jun 28, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ karpovas1505
❌ as.karpov1


as.karpov1 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@nicoschoenteich nicoschoenteich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karpovas1505, thanks a lot. We are running into an error again, but this time I know why. Can you change the chromdriver version back to ^101.0.0 and do an npm install and then push the changes? The tests are going to fail on your local machine, but hopefully pass in the GitHub action. Even if we don't get the tests to pass here in GitHub, we consider your challenge entry as successful anyway 🤙

@karpovas1505
Copy link
Author

Hi @karpovas1505, thanks a lot. We are running into an error again, but this time I know why. Can you change the chromdriver version back to ^101.0.0 and do an npm install and then push the changes? The tests are going to fail on your local machine, but hopefully pass in the GitHub action. Even if we don't get the tests to pass here in GitHub, we consider your challenge entry as successful anyway 🤙

Hi @nicogeburek I added a new commit

@nicoschoenteich
Copy link
Contributor

Hi @karpovas1505, thanks a lot! The GitHub action always pulls the latest chrome version, and since there is a new version, we need chromedriver version 103 now 😅 Not the best design, but we made it work anyway. Good job and thanks for taking part!

@karpovas1505
Copy link
Author

Hi @karpovas1505, thanks a lot! The GitHub action always pulls the latest chrome version, and since there is a new version, we need chromedriver version 103 now 😅 Not the best design, but we made it work anyway. Good job and thanks for taking part!

Hi @nicogeburek "1 workflow awaiting approval". Can you approve or I need some actions?

@nicoschoenteich
Copy link
Contributor

Hi @karpovas1505, looks like one test you wrote for week 4 is not passing. Do you have an idea why that is?

@karpovas1505
Copy link
Author

Hi @karpovas1505, looks like one test you wrote for week 4 is not passing. Do you have an idea why that is?

Hi @nicogeburek, in my case I opened both view as in your example week4.test.js(code below), the first test case I wrote in Main.view and the second in Detail.view, but it it doesn't work in one test file. And I moved all test in one file and it works fine. Approve my new commit please.

before(async () => {
    await Main.open()
    // or
    await Detail.open()
})

@nicoschoenteich
Copy link
Contributor

Works! Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants