-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
as.karpov1 Week 1,2,3 #40
base: main
Are you sure you want to change the base?
Conversation
as.karpov1 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karpovas1505, thanks a lot. We are running into an error again, but this time I know why. Can you change the chromdriver version back to ^101.0.0
and do an npm install
and then push the changes? The tests are going to fail on your local machine, but hopefully pass in the GitHub action. Even if we don't get the tests to pass here in GitHub, we consider your challenge entry as successful anyway 🤙
Hi @nicogeburek I added a new commit |
Hi @karpovas1505, thanks a lot! The GitHub action always pulls the latest chrome version, and since there is a new version, we need chromedriver version 103 now 😅 Not the best design, but we made it work anyway. Good job and thanks for taking part! |
Hi @nicogeburek "1 workflow awaiting approval". Can you approve or I need some actions? |
Hi @karpovas1505, looks like one test you wrote for week 4 is not passing. Do you have an idea why that is? |
Hi @nicogeburek, in my case I opened both view as in your example week4.test.js(code below), the first test case I wrote in Main.view and the second in Detail.view, but it it doesn't work in one test file. And I moved all test in one file and it works fine. Approve my new commit please.
|
Works! Good job! |
Hi @nicogeburek
It is my results