Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week 1 test passed #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Julien-Minder
Copy link

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Jun 16, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@nicoschoenteich nicoschoenteich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Julien-Minder,
Looks good! Thanks for taking part in the challenge. We have added a test file for week 2 already. You can fetch the upstream and check it out.
BR, Nico

@nicoschoenteich
Copy link
Contributor

Hi @Julien-Minder, if you want to sign the CLA, we can then also run the wdi5 tests here as an GitHub action. Optional, of course.
BR, Nico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants