Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

week1 test #18

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

week1 test #18

wants to merge 10 commits into from

Conversation

miyasuta
Copy link

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Jun 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ miyasuta
❌ nicogeburek


nicogeburek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cla-assistant
Copy link

cla-assistant bot commented Jun 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nicoschoenteich
Copy link
Contributor

Hi @miyasuta, thanks for taking part in the challenge!
We had some issues with the starter project and its package-lock.json, which is why the GitHub action failed. But your app looks fine, so I would still consider it a successful entry for the first week. You can either fetch the upstream and update your PR if you want or just wait until Wednesday, when we will add a new test to the project.

@nicoschoenteich
Copy link
Contributor

Hi @miyasuta, I hope it's ok I updated your app to make the GitHub action pass. I had to tweak the action a little and disable the caching - this was bad configuration from my side when setting up the project. Anyway, you are now all set up.

@miyasuta
Copy link
Author

Hi @nicogeburek ,

I have updated my repo to pass week2 and week3 tests. I'm trying create a new pull request, but my changes are somehow tied to this existing pull request. Should I close this request first and create a new one?

@miyasuta
Copy link
Author

I have created a new branch in my repo and created a pull request from there. Problem solved!

@nicoschoenteich
Copy link
Contributor

Hi @miyasuta, good job! We will add a new test file for week4 on Wednesday ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants