-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
week1 test #18
base: main
Are you sure you want to change the base?
week1 test #18
Conversation
nicogeburek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi @miyasuta, thanks for taking part in the challenge! |
Hi @miyasuta, I hope it's ok I updated your app to make the GitHub action pass. I had to tweak the action a little and disable the caching - this was bad configuration from my side when setting up the project. Anyway, you are now all set up. |
Hi @nicogeburek , I have updated my repo to pass week2 and week3 tests. I'm trying create a new pull request, but my changes are somehow tied to this existing pull request. Should I close this request first and create a new one? |
I have created a new branch in my repo and created a pull request from there. Problem solved! |
Hi @miyasuta, good job! We will add a new test file for week4 on Wednesday ✅ |
No description provided.