Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAP UI5 code Challenge #17

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

HexClan-dev
Copy link

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Jun 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ HexClan-dev
❌ nicogeburek


nicogeburek seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nicoschoenteich
Copy link
Contributor

Hi @HexClan-dev , thanks for taking part in the challenge!
We had some issues with the starter project and its package-lock.json, which is why the GitHub action failed. But your app looks fine, so I would still consider it a successful entry for the first week. I think it's best if you delete your package-lock.json and then generate a new one (npm install). You can do that PR if you want or just wait until Wednesday, when we will add a new test to the project.

@nicoschoenteich
Copy link
Contributor

Hi @HexClan-dev, we found and fixed the real issue which was causing the action to fail. Fetching the upstream should update this PR and make the action succeed.

@HexClan-dev
Copy link
Author

Hi @nicogeburek , Perfect, Many thanks!

@HexClan-dev HexClan-dev changed the title Week1 Challenge SAP UI5 code Challenge Jun 20, 2022
@nicoschoenteich
Copy link
Contributor

Hi @HexClan-dev, good job! You can also check out the newest test file for week3 if you want 😉

@nicoschoenteich
Copy link
Contributor

Good job! Thanks for taking part. I just had to adjust the chromedriver version, as the GitHub action pulls the latest chrome version and the driver has to match. You might want to change it back for local development depending on your local chrome installation 🤙

@HexClan-dev
Copy link
Author

Perfect! Many thanks @nicogeburek !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants