Fix testing PHP 7.0 #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondermatic
commented
Nov 13, 2017
pondermatic
commented
- Testing with PHP 7.0 was failing because PHPUnit 6.4 was used, which breaks compatibility with PHPUnit 4.8.* and 5.4.*.
- Updated tests for PHP 7.1 change to handling "too few arguments" error.
This allows the tests to be run with PHPUnit 4.8.*, 5.4.* and 6.*.
'@stable' causes testing of PHP 7.0 to use PHPUnit 6.4, which breaks compatibility with PHPUnit 4.8 and 5.7.
If the HTTP header context option is an array of headers, HHVM sends an 'Array to string conversion' notice.
This was referenced Nov 13, 2017
Open
HHVM needs to fix 'Array to string conversion' issue instead of TinCanPHP working around it.
|
I think it's better to use symfony/phpunit-bridge which automatically downloads the correct phpunit version depending on the PHP version used. Then if you're using (deprecated) methods only available in older or newer versions you can check for the phpunit version used and conditionally use the correct method. Usually no big changes are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.