Agentetagnone

[garemoko]

@brianjmiller this is ready for you to review.

It solves a problem where if the etag options property is not set, both saveActivityProfile and saveAgentProfile will not set the etag header, which is a bad request and will result in a conformant LRS returning 400. This means that in scenarios where there is no etag (e.g. the resource is being PUT for the first time), there's no way to make a valid request.

I did consider that since this is a change in behavior, we should add an additional 'if-none' options property to allow people to explicitly set the if-none-match header, however since a conformant LRS will always reject requests without that header, I didn't see the point in supporting not setting that header.

This PR does nothing to address the related issue that there is no way to set the If-None-Match header for PUT requests to the State API. In that case, the etag header is optional so we would need to continue to support sending no-etag-header requests to avoid a breaking change.

This PR has been tested with the Moodle xAPI launch plugin and I have confirmed that this change fixes davidpesce/moodle-mod_tincanlaunch#140.

[WillSkates]

Hey @garemoko. You will need the fixes in #83 for this.

[davidpesce]

Any word on the status of this PR? This looks like it'll fix the issue I'm running into with the new version of LL.

[garemoko]

Any news on getting this merged? I'm planning another release of the Moodle launch plugin in the next couple of months and would rather not fork/edit TinCanPHP in that release.