Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpufeatures: fix macOS build #1066

Merged
merged 1 commit into from
Apr 24, 2024
Merged

cpufeatures: fix macOS build #1066

merged 1 commit into from
Apr 24, 2024

Conversation

tarcieri
Copy link
Member

The "sm4" token wasn't being handled. To fix the bleeding, this adds it but hardcoded to disabled.

See build failure here: https://github.com/RustCrypto/utils/actions/runs/8818083683/job/24206057206?pr=1065

   Compiling cpufeatures v0.2.12 (/Users/runner/work/utils/utils/cpufeatures)
error: no rules expected the token `"sm4"`
   --> tests/aarch64.rs:5:51
    |
5   | cpufeatures::new!(armcaps, "aes", "sha2", "sha3", "sm4");
    |                                                   ^^^^^ no rules expected this token in macro call
    |
note: while trying to match `"aes"`
   --> /Users/runner/work/utils/utils/cpufeatures/src/aarch64.rs:107:6
    |
107 |     ("aes") => {
    |      ^^^^^

The "sm4" token wasn't being handled. To fix the bleeding, this adds it
but hardcoded to disabled.

See build failure here: https://github.com/RustCrypto/utils/actions/runs/8818083683/job/24206057206?pr=1065
@tarcieri
Copy link
Member Author

I haven't researched if Apple CPUs support this. I just want the crate to compile again, since it's blocking #1065.

@tarcieri tarcieri merged commit c0eab7f into master Apr 24, 2024
11 checks passed
@tarcieri tarcieri deleted the cpufeatures/fix-macos-build branch April 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant