Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signature_derive: adds support for lifetimes #1641

Closed

Conversation

baloo
Copy link
Member

@baloo baloo commented Aug 6, 2024

This allows to writes things like:

#[derive(Debug, Signer)]
pub struct EcSigner<'ctx, C>
where
    C: PrimeCurve + CurveArithmetic,
{
    context: Mutex<&'ctx mut TransientKeyContext>,
}

Usecase: parallaxsecond/rust-tss-esapi#537

@baloo baloo marked this pull request as draft August 6, 2024 23:17
@baloo baloo force-pushed the baloo/signature_derive/lifetime-support branch from b76ff3a to 148d9ce Compare August 6, 2024 23:30
@baloo baloo marked this pull request as ready for review August 6, 2024 23:30
@baloo baloo closed this Aug 7, 2024
@baloo baloo deleted the baloo/signature_derive/lifetime-support branch August 7, 2024 02:11
@tarcieri
Copy link
Member

tarcieri commented Aug 7, 2024

Why'd you close this?

@baloo
Copy link
Member Author

baloo commented Aug 8, 2024

because I realized it was easy enough to implement manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants