Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to doc_auto_cfg #1370

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Migrate to doc_auto_cfg #1370

merged 1 commit into from
Oct 31, 2023

Conversation

tarcieri
Copy link
Member

Migrates the aead, cipher, crypto-common, digest, and universal-hash crates to use the doc_auto_cfg feature which automatically generates documentation for cfg-gated code, which in our uses is almost exclusively gated on crate features.

This allows the previous manual doc_cfg annotations to be removed, which is nice as they otherwise duplicate work whenever cfg-gated code is used.

Migrates the `aead`, `cipher`, `crypto-common`, `digest`, and
`universal-hash` crates to use the `doc_auto_cfg` feature which
automatically generates documentation for `cfg`-gated code, which in our
uses is almost exclusively gated on crate features.

This allows the previous manual `doc_cfg` annotations to be removed,
which is nice as they otherwise duplicate work whenever `cfg`-gated code
is used.
@tarcieri tarcieri requested a review from newpavlov October 31, 2023 14:14
@tarcieri tarcieri merged commit bbcb9c2 into master Oct 31, 2023
43 checks passed
@tarcieri tarcieri deleted the doc_auto_cfg branch October 31, 2023 14:42
tarcieri added a commit that referenced this pull request Jan 8, 2024
These were leftover from the migration to `doc_auto_cfg` in #1370.

They're breaking the doc build.
tarcieri added a commit that referenced this pull request Jan 8, 2024
These were leftover from the migration to `doc_auto_cfg` in #1370.

They're breaking the doc build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants