signature: add traits to obtain verifier objects #1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
My bad, I think that will cover my use cases. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I occasionally encounter situations where I need to get a verifier from a signer, and have to pass both to a method since there's currently no generic mechanism to do that.
ecdsa::SigningKeyhas averifying_key()method, but it's not in any trait, so if my code is generic over Signer/Verifier traits, I can't use it.Would it make sense to add a trait for that connection? Are there any situations where a signer object does not allow one to obtain the corresponding verifier? If not, we can even bound
Singer<S>: HasVerifier<S>.