der_derive: use TryFrom conversions for asn1(type = ...)
#1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was using `<asn1_type>::new`. Using `TryFrom` is more flexible in terms of the possible conversions that it permits. Also fills out the missing `From`/`TryFrom` conversions needed for the existing crates in this repo (most notably `x509-cert` to compile with the changes).
tarcieri
force-pushed
the
der_derive/use_try_from_asn1_type
branch
from
6b4af73 to
3ba3224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was using
<asn1_type>::new.Using
TryFromis more flexible in terms of the possible conversions that it permits.Also fills out the missing
From/TryFromconversions needed for the existing crates in this repo (most notablyx509-certto compile with the changes).