Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

der-derive: v0.7.3 #1443

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Conversation

baloo
Copy link
Member

@baloo baloo commented Jul 9, 2024

Changed

  • avoid type inference when using default (#1443)

baloo and others added 2 commits July 9, 2024 11:02
* Revert "x509-cert: specify concrete types to help the compiler (RustCrypto#1441)"

This reverts commit 7a2d38a.

* der-derive: avoid type inference when using default

This is another take on RustCrypto#1441. This is intended to make sure we can
still continue to use `Default::default` and not break future releases
by mistake.
Changed (2024-07-09)
- avoid type inference when using default (RustCrypto#1443)
@baloo
Copy link
Member Author

baloo commented Jul 9, 2024

This is a backport of #1442 and #1441 for der-derive 0.7

@baloo
Copy link
Member Author

baloo commented Jul 9, 2024

I think this will fail clippy because of unused_qualification

@tarcieri
Copy link
Member

tarcieri commented Jul 9, 2024

@baloo it should be pinned to whatever built at the time

@tarcieri
Copy link
Member

tarcieri commented Jul 9, 2024

Aah, but all the tests run against stable

@baloo baloo merged commit a4ad7d0 into RustCrypto:der/v0.7 Jul 9, 2024
172 checks passed
@baloo baloo deleted the baloo/der-derive/v0.7.3 branch July 9, 2024 20:34
@baloo
Copy link
Member Author

baloo commented Jul 9, 2024

@istankovic

https://crates.io/crates/der-derive/0.7.3

cargo update -p der_derive should fix the issue for you.

@istankovic
Copy link
Contributor

Thanks @baloo and @tarcieri, this is very much appreciated!

istankovic added a commit to wireapp/core-crypto that referenced this pull request Jul 12, 2024
Upstream has made a fix and released a new version of der_derive:
RustCrypto/formats#1443
SimonThormeyer pushed a commit to wireapp/core-crypto that referenced this pull request Jul 15, 2024
Upstream has made a fix and released a new version of der_derive:
RustCrypto/formats#1443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants