-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
der-derive: v0.7.3 #1443
Merged
Merged
der-derive: v0.7.3 #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "x509-cert: specify concrete types to help the compiler (RustCrypto#1441)" This reverts commit 7a2d38a. * der-derive: avoid type inference when using default This is another take on RustCrypto#1441. This is intended to make sure we can still continue to use `Default::default` and not break future releases by mistake.
Changed (2024-07-09) - avoid type inference when using default (RustCrypto#1443)
I think this will fail clippy because of |
@baloo it should be pinned to whatever built at the time |
Aah, but all the tests run against |
This fixes all `unnecessary qualification` warnings
https://crates.io/crates/der-derive/0.7.3
|
istankovic
added a commit
to wireapp/core-crypto
that referenced
this pull request
Jul 12, 2024
Upstream has made a fix and released a new version of der_derive: RustCrypto/formats#1443
3 tasks
SimonThormeyer
pushed a commit
to wireapp/core-crypto
that referenced
this pull request
Jul 15, 2024
Upstream has made a fix and released a new version of der_derive: RustCrypto/formats#1443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed