der: return Tag::Integer.length_error() on empty ints
#1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From X.690 § 8.3.1: > 8.3 Encoding of an integer value > 8.3.1 The encoding of an integer value shall be primitive. > The contents octets shall consist of one or more octets.
tarcieri
force-pushed
the
der/return-errorkind-length-empty-integer
branch
from
341d683 to
e0cefea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From X.690 § 8.3.1:
Previously this returned
ErrorKind::Noncanonical, however this restriction applies to all INTEGER encodings including BER, soErrorKind::Lengthis more appropriate.