Make sure der crate is compatible with potential language breaking changes
#1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`?` currently influences inference s.t. for `error()?` rustc infers `T = ()`. However, it is quite confusing -- `?` is not supposed to influence inference, it's just a conicidence because of the curent implementation. There is an idea to change this behavior in future Rust versions, such that this code won't compile without this change.
WaffleLapkin
deleted the
fixup-der-to-be-compatible-with-future-rust-changes
branch
|
@WaffleLapkin this is going to take a little while until we tag a (stable) release for der. |
|
cargo currently uses |
baloo
pushed a commit
that referenced
this pull request
Apr 1, 2024
`?` currently influences inference s.t. for `error()?` rustc infers `T = ()`. However, it is quite confusing -- `?` is not supposed to influence inference, it's just a conicidence because of the curent implementation. There is an idea to change this behavior in future Rust versions, such that this code won't compile without this change.
baloo
added a commit
to baloo/formats
that referenced
this pull request
Apr 1, 2024
Changed - make sure der is comptatible with potential language breaking changed (backport of RustCrypto#1374)
Merged
baloo
added a commit
to baloo/formats
that referenced
this pull request
Apr 1, 2024
Changed - make sure der is comptatible with potential language breaking changed (backport of RustCrypto#1374) - ignore RUSTSEC-2023-0071 (backport of RustCrypto#1276)
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Apr 2, 2024
Update `der` crate This soft-blocks some of my work on testing things with the never type, see RustCrypto/formats#1374.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?currently influences inference s.t. forerror()?rustc infersT = (). However, it is quite confusing --?is not supposed to influence inference, it's just a conicidence because of the curent implementation. There is an idea to change this behavior in future Rust versions, such that this code won't compile without this change.See rust-lang/rust#122412 for more information about the change.
(
deris used by cargo, so this partially blocks the PR, please ping me once you release a newderversion so I can update it inside cargo)