Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x509-ocsp: implement builder #1259

Merged
merged 28 commits into from
Jan 8, 2024

Conversation

bhesh
Copy link
Contributor

@bhesh bhesh commented Nov 17, 2023

Fixed a bug with CrlReferences/CrlId extensions, added a ton of tests, and implemented a basic builder. Optional rand, builder, and std features.

@bhesh
Copy link
Contributor Author

bhesh commented Nov 17, 2023

To keep all changes in x509-ocsp, I implemented a GeneralizedTime wrapper called OcspGeneralizedTime. But I think a UtcTime -> GeneralizedTime conversion makes sense in der. And possibly a x509_cert::time::Time -> GeneralizedTime. OCSP just doesn't support the legacy UtcTime and the conversion code was repeated too often in the builders.

@bhesh
Copy link
Contributor Author

bhesh commented Nov 17, 2023

I merged the latest master with the workflow changes but the issues still persist. I'm not sure what the problem is.

Edit: changed the offending workflows: nightly_cmd -> nightly-cmd

x509-ocsp/src/ext.rs Outdated Show resolved Hide resolved
@tarcieri
Copy link
Member

tarcieri commented Jan 7, 2024

@bhesh I'd like to get this merged, but it looks like it needs a rebase

@bhesh
Copy link
Contributor Author

bhesh commented Jan 7, 2024

Rebasing was causing me a lot of issues. I just merged with the latest master

@tarcieri tarcieri merged commit c59f97e into RustCrypto:master Jan 8, 2024
160 checks passed
@tarcieri tarcieri mentioned this pull request Jan 8, 2024
@tarcieri
Copy link
Member

tarcieri commented Jan 8, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants