functional-testing: Add test for GCCRS_EXTRA_ARGS #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
approved these changes
Jul 16, 2021
bjorn3
reviewed
Jul 16, 2021
| assert!(Harness::check_folder("invalid_code", FileType::Bin).is_err()) | ||
| assert!(Harness::check_folder("invalid_code", FileType::Bin).is_err()); | ||
|
|
||
| std::env::set_var("GCCRS_EXTRA_ARGS", "-Werror"); |
There was a problem hiding this comment.
This will only work fine if you ensure that no other test is running at the same time. Currently there are no other tests, but I don't know if that will change in the future.
There was a problem hiding this comment.
Yeah, but we are having issues with that in the whole harness since we also use env::set_current_dir(). I think it should only be "one test" that calls multiple functions. I mentioned it somewhere in a previous PR about testing, that since there was no way to set --test-threads=1 from a configuration file it was impossible to do otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44