example: custom callback in event poller #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamamsmith
reviewed
Jun 8, 2023
| client.add_pair(pair_name="WETH/USDC") # , base_asset_allowance=Decimal("1"), quote_asset_allowance=Decimal("2000") | ||
|
|
||
| # start listening to offer events created by your wallet on the WETH/USDC market and the WETH/USDC orderbook | ||
| client.start_event_poller("WETH/USDC", event_type=EmitOfferEvent, event_handler=partial(compare_eth_offer, base_asset=base_asset, quote_asset=quote_asset)) |
There was a problem hiding this comment.
While this does work I think it is more complicated for users and shouldn't be advertised as the default path
There was a problem hiding this comment.
i agree, i think the approach shown in #35 and more broadly in #34 is a much better approach, separates out the event handling logic to be based off the queue instead of at the event_poller level. lets definitely point user's to this pattern as the default, and we can simply have the event_handler buried a bit deeper with a clear breakdown of required structure for users who still choose to go this route.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adamamsmith wanted to get your thoughts on this before writing up supporting docs, any other patterns/best practices you think we should show when it comes to
event_handleronclient.start_event_poller? could we be demonstrating this functionality in a better way? this is a great feature, let me know however i can be of help