Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adicionado as configurações para o App Link de redirecionamento #105

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

CroyzCamel
Copy link
Contributor

Issue

This pull request refers to Issue #101

  • Does not apply to this pull request

Description

Adicionado configuração ao manifest para domain;
Adicionado deepLink no NavGraph;

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with develop (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

OdisBy
OdisBy previously approved these changes Nov 27, 2024
Copy link
Collaborator

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei alguns comentários, vê se você acha válido ou não.

Como não sei como está a sprint no momento e as próximas n posso dizer se está correto ou não algumas partes, como o mock.

Sobre a linha no final do arquivo não é obrigatório, mas legal seguirmos com a linha extra.

Fora isso parabéns por conseguir implementar o Deep Link 💯

Copy link
Collaborator

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa boa!!

@CroyzCamel CroyzCamel requested a review from OdisBy November 27, 2024 19:00
Copy link
Collaborator

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ficou ótimo, parabéns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants