Keep .is-selected on the program-flow header when it's edited via the sidebar
#1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #42651: Program flow header's |
Passing run #5790 ↗︎
Details:
Review all test suite changes for PR #1178 ↗︎ |
|||||||||||||||
Pull Request Test Coverage Report for Build 43718550-e5db-4fa3-af2b-37b451542ee9
💛 - Coveralls |
paulfalgout
requested changes
Oct 25, 2023
| @@ -97,6 +94,17 @@ const HeaderView = View.extend({ | |||
| }, | |||
| }); | |||
|
|
|||
| const AddActionView = View.extend({ | |||
| template: hbs` | |||
There was a problem hiding this comment.
program-flow__actions should just be the className here and the template just the button
There was a problem hiding this comment.
Good call, that's been updated 👍
… is edited via the sidebar
nmajor25
force-pushed
the
program-flow-header-selected
branch
from
d506949 to
53cdada
Compare
paulfalgout
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcut Story ID: [sc-42651]
.is-selectedgives the program flow header a grey background to indicate that it's currently being edited via the sidebar:When a user makes a change via the program-flow sidebar, the
.is-selectedclass was being dropped when that header view re-rendered. But as long as the sidebar is open and the user is editing the program-flow, we want the.is-selectedclass to remain.