Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abilty to correctly inform cargo of file dependnencies in build.rs #139

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Abilty to correctly inform cargo of file dependnencies in build.rs #139

merged 1 commit into from
Oct 8, 2023

Conversation

Carter12s
Copy link
Collaborator

@Carter12s Carter12s commented Oct 5, 2023 •
edited
Loading

Description

See changelog.

Fixes

Issue Number: None (just went for it)

Checklist

  • Update CHANGELOG.md

@Carter12s Carter12s requested a review from ssnover October 5, 2023 18:23
@Carter12s Carter12s self-assigned this Oct 5, 2023
ssnover
ssnover approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@ssnover ssnover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ssnover
ssnover requested changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@ssnover ssnover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the test failure appears to be a real failure.

@Carter12s
Copy link
Collaborator Author

I believe test failure here is #141 and resolve by changes in #140 not going to address on this MR.

@Carter12s
Copy link
Collaborator Author

Going ahead and merging, will plan on fixing tests with continued work in #140

@Carter12s Carter12s merged commit 7c248ea into master Oct 8, 2023
3 of 4 checks passed
@Carter12s Carter12s deleted the codegen-dependent-files branch May 21, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssnover ssnover ssnover requested changes

Assignees

@Carter12s Carter12s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Carter12s @ssnover