Generate application form from Jinja template #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonjaPonja
requested changes
Apr 20, 2019
There was a problem hiding this comment.
This is a great start already. Makes editing the main file suck much less.
I'm not super sure, but it may be better to just move all css/js/jinja files into a flat src/ directory or something. I don't think we will get so many files for many directories to be useful.
|
Ok, all the included files are in |
RonjaPonja
approved these changes
Apr 21, 2019
|
Looks good to me. Maybe you want to have another look @vollkorn1982 ? |
|
I'll just merge this now. |
|
@HerrSpace Thanks both of you. Have been too busy lately to take a break for this, but it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #40 (I hope): adds a script and Jinja template for the application form that generates almost identical HTML. (
git diff -wonly reports the BOM disappearing.)If this is what you were thinking of in terms of templating, next steps could be splitting the CSS into separate screen and print files and making the input field synchronisation flexible about which fields are in the form.