Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed codingBySearch #29

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

PhilippKuntschik
Copy link

@PhilippKuntschik PhilippKuntschik commented Apr 1, 2019

Dear Ronggui,

I tried myself on fixing and enhancing the codingBySearch function:

  • fixed a bug with a misspelled variable name that broke concatenation functionality: 2e1b9be
  • added comments and renamed local variable names for better maintainability.
  • improved functionality to allow more fine grained search and code functionality: 0166f72

I was especially interested in fixing cases, where the coding search pattern spanned across multiple analysis units (e.g. multi word patterns combined with a space separator). I took special care on the concatenate functionality to keep compatibility.

I tested with the following examples:

multi word

"The Semantic Web shares many goals with Decision Support Systems DSS, e.g., being able to precisely interpret information, in order to deliver relevant, reliable and accurate information to a user when and where it is needed."

codingBySearch("Decision Support System", fid=getFileIds(), cid=1, seperator="[ .,;-]")

concatenation

"Large amounts of Linked Data Linked Data geo-spatial information have been made available with the growth of the Web of Data."

codingBySearch("Linked Data", fid=getFileIds(), cid=1, seperator="[ .,;-]", concatenate=TRUE)

concatenation 2

"The Subject-Predicate-Object triple annotation system is now well adopted in the research community, however, it does not always speak to end-users."

codingBySearch("Subject|Predicate|Object", fid=getFileIds(), cid=1, seperator="[ .,;-]", concatenate=TRUE)

sub-word

"We organize these building blocks of dataset profiling in a taxonomy."

codingBySearch("ld", fid=getFileIds(), cid=1, seperator="[ .,;-]", concatenate=TRUE)

@Chris-JAC
Copy link

Thanks Philipp, this code closes down a whole lot of errors on the dbFetch. Appreciate your efforts in this ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants