Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo application #30

Merged
merged 17 commits into from
Dec 26, 2024
Merged

Add demo application #30

merged 17 commits into from
Dec 26, 2024

Conversation

kerne1s
Copy link
Collaborator

@kerne1s kerne1s commented Aug 26, 2024

@kerne1s kerne1s self-assigned this Aug 26, 2024
@kerne1s kerne1s changed the base branch from main to prd-1187-react-lib-nextjs-support August 26, 2024 09:31
@kerne1s kerne1s requested a review from ipakhomov August 26, 2024 09:39
@kerne1s kerne1s assigned ipakhomov and unassigned kerne1s Sep 3, 2024
@ipakhomov ipakhomov requested a review from ekazankova September 9, 2024 08:40
@ekazankova ekazankova assigned kerne1s and unassigned ipakhomov Sep 9, 2024
@kerne1s
Copy link
Collaborator Author

kerne1s commented Sep 10, 2024

@ekazankova please review

@kerne1s kerne1s requested a review from ekazankova September 10, 2024 06:42
@kerne1s kerne1s assigned ekazankova and unassigned kerne1s Sep 10, 2024
@ekazankova ekazankova assigned kerne1s and ipakhomov and unassigned ekazankova and kerne1s Sep 10, 2024
@kerne1s kerne1s assigned ipakhomov and unassigned kerne1s Sep 23, 2024
@ipakhomov
Copy link
Collaborator

Blocked by this issue

@ipakhomov
Copy link
Collaborator

@kerne1hub could you please update this PR with latest changes you have in generators and common modules?

@ipakhomov ipakhomov assigned kerne1s and unassigned ipakhomov Oct 29, 2024
@kerne1s kerne1s assigned ipakhomov and unassigned kerne1s Oct 30, 2024
@ipakhomov
Copy link
Collaborator

@kerne1s please update this PR with latest changes

@ipakhomov ipakhomov assigned kerne1s and unassigned ipakhomov Dec 25, 2024
@kerne1s kerne1s requested a review from ekazankova December 26, 2024 08:15
@kerne1s kerne1s assigned ipakhomov and unassigned kerne1s Dec 26, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this file can be removed because lint script already passes the ESLINT_USE_FLAT_CONFIG variable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file is used by NX generators, so without it NX by default will use eslint.config.js for libs

@ipakhomov ipakhomov assigned kerne1s and unassigned ipakhomov Dec 26, 2024
@kerne1s kerne1s assigned ipakhomov and unassigned kerne1s Dec 26, 2024
@ekazankova ekazankova merged commit fa801f7 into main Dec 26, 2024
@ekazankova ekazankova deleted the prd-1190-demo branch December 26, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants