86byre0hx: Implemented sentry generator #23
Conversation
|
|
||
| Sentry.init({ | ||
| // TODO replace with your DSN | ||
| dsn: '', |
There was a problem hiding this comment.
@rbd2q Let's add one more question to the Sentry generator schema to prompt the user to enter the DSN, paste the provided DSN value here and remove the TODO comment above.
|
|
||
| Sentry.init({ | ||
| // TODO replace with your DSN | ||
| dsn: '', |
There was a problem hiding this comment.
@rbd2q Let's add one more question to the Sentry generator schema to prompt the user to enter the DSN, paste the provided DSN value here and remove the TODO comment above.
| import * as path from 'path'; | ||
| import { SentryGeneratorSchema } from './schema'; | ||
|
|
||
| const webDependencies = { |
There was a problem hiding this comment.
@rbd2q I'd suggest to rename this to nextAppDependencies.
| const webDependencies = { | |
| const nextAppDependencies = { |
| '@sentry/nextjs': '^8.21.0', | ||
| }; | ||
|
|
||
| const mobileDependencies = { |
There was a problem hiding this comment.
@rbd2q I'd suggest to rename this to expoAppDependencies.
| const mobileDependencies = { | |
| const expoAppDependencies = { |
| ) { | ||
| const projectRoot = `apps/${options.directory}`; | ||
|
|
||
| if (tree.exists(`${projectRoot}/next.config.js`)) { |
There was a problem hiding this comment.
@rbd2q Let's create an utility function called isNextApp and use it here.
| }); | ||
|
|
||
| generateFiles(tree, path.join(__dirname, 'files'), projectRoot, options); | ||
| } else if (tree.exists(`${projectRoot}/metro.config.js`)) { |
There was a problem hiding this comment.
@rbd2q Let's create an utility function called isExpoApp and use it here.
| const nextConfigContent = tree | ||
| .read(`${projectRoot}/next.config.js`) | ||
| .toString() | ||
| .replace( |
There was a problem hiding this comment.
@rbd2q Unfortunately, the method of replacing anchor strings is unreliable and will eventually fail without warning. This can happen if someone changes the anchors, e.g. by adding or rearranging imports.
Can we instead work directly with the Abstract Syntax Tree (AST)? This would make the generator more stable and less reliant on specific anchors.
For more details and an example, see: https://nx.dev/extending-nx/recipes/modifying-files#ast-manipulation.
|
|
||
| Sentry.init({ | ||
| // TODO replace with your DSN | ||
| dsn: '', |
There was a problem hiding this comment.
@rbd2q Let's add one more question to the Sentry generator schema to prompt the user to enter the DSN, paste the provided DSN value here and remove the TODO comment above.
No description provided.