feat: Store documentation file on a configurable directory #152
+82
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hans-thomas I've updated task description, please add required changes accordingly the new task description (please feel free to open few PRs if you can divide task for small subtasks without breaking the package work) |
|
@hans-thomas please do not use autoclosing issues as we need to test task before closing |
The `production_path` key renamed to `base_file_name` for both local and storage drivers;
|
hans-thomas
commented
Dec 28, 2024
| throw new MissedProductionFilePathException(); | ||
| } | ||
| } | ||
|
|
||
| public function saveData(): void | ||
| { | ||
| $this->disk->put($this->prodFilePath, json_encode($this->getTmpData())); | ||
| $this->disk->put($this->baseFileName, json_encode($this->getTmpData())); |
There was a problem hiding this comment.
- Storage driver should create storage directory only for non Cloud drivers (on documentation saving)
I believe the Filesystem class will take care of it.
|
Hi @DenTray, would you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, it adds the ability to store the generated documentation file in a configurable directory.
TODO list:
directorywith the default valuedocumentationsproduction_pathconfig for Local and Storage drivers should be renamed tobase_file_namewith the default valuedocumentation(without.jsonextension).jsonextension