feat: set up project to use Paratest #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DenTray Could you please review this one? |
DenTray
requested changes
Oct 14, 2024
vitgrams
force-pushed
the
paratests
branch
2 times, most recently
from
4f5f786 to
c64db73
Compare
vitgrams
force-pushed
the
paratests
branch
9 times, most recently
from
1a303da to
d4e0f6e
Compare
…ngle file for saving to production;
|
@DenTray Could you please take a look at this again? |
DenTray
requested changes
Dec 3, 2024
|
@DenTray Done. Could you please take a look? |
|
DenTray
requested changes
Dec 10, 2024
| throw new RuntimeException('Unable to lock file'); | ||
| } | ||
|
|
||
| usleep(rand($minWaitTime, $maxWaitTime)); |
There was a problem hiding this comment.
Suggested change
| usleep(rand($minWaitTime, $maxWaitTime)); | |
| usleep($waitTime); |
|
|
||
| protected function writeFileWithLock(string $filePath, callable $callback): void | ||
| { | ||
| $handle = fopen($filePath, 'c+'); |
There was a problem hiding this comment.
Suggested change
| $handle = fopen($filePath, 'c+'); | |
| $fileResource = fopen($filePath, 'c+'); |
|
|
||
| protected function writeFileWithLock(string $filePath, callable $callback): void | ||
| { | ||
| $handle = fopen($filePath, 'c+'); |
There was a problem hiding this comment.
please move c+ value to the user readable constant
Comment on lines
+20
to
+22
| if (ParallelTesting::token()) { | ||
| $swaggerService->mergeTempDocumentation(); | ||
| } |
There was a problem hiding this comment.
please move it into the saveProductionData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done: