[feat]: update openapi version #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenTray
approved these changes
Oct 7, 2024
Comment on lines
+336
to
+338
| $definitions = (!empty($this->data['components']['schemas'])) ? $this->data['components']['schemas'] : []; | ||
|
|
||
| $properties = Arr::get($definitions, $definition, []); |
There was a problem hiding this comment.
Suggested change
| $definitions = (!empty($this->data['components']['schemas'])) ? $this->data['components']['schemas'] : []; | |
| $properties = Arr::get($definitions, $definition, []); | |
| $properties = Arr::get($this->data, "components.schemas.{$definition}", []); |
| $this->item['parameters'][] = [ | ||
| 'in' => 'body', | ||
| 'name' => 'body', | ||
| $type = $this->request->header('Content-Type') ?? 'application/json'; |
There was a problem hiding this comment.
Suggested change
| $type = $this->request->header('Content-Type') ?? 'application/json'; | |
| $type = $this->request->header('Content-Type', 'application/json'); |
| 'content' => [ | ||
| $type => [ | ||
| 'schema' => [ | ||
| "\$ref" => "#/components/schemas/{$actionName}Object", |
There was a problem hiding this comment.
Suggested change
| "\$ref" => "#/components/schemas/{$actionName}Object", | |
| '$ref' => "#/components/schemas/{$actionName}Object", |
| @@ -559,7 +577,7 @@ protected function saveDefinitions($objectName, $rules, $attributes, array $anno | |||
| } | |||
|
|
|||
| $data['example'] = $this->generateExample($data['properties']); | |||
| $this->data['definitions'][$objectName . 'Object'] = $data; | |||
| $this->data['components']['schemas'][$objectName . 'Object'] = $data; | |||
There was a problem hiding this comment.
Suggested change
| $this->data['components']['schemas'][$objectName . 'Object'] = $data; | |
| $this->data['components']['schemas']["{$objectName}Object"] = $data; |
Comment on lines
+621
to
625
| if (isset($this->data['components']['schemas'][$actionName . 'Object']['properties'])) { | ||
| $objectParametersCount = count($this->data['components']['schemas'][$actionName . 'Object']['properties']); | ||
| } else { | ||
| $objectParametersCount = 0; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (isset($this->data['components']['schemas'][$actionName . 'Object']['properties'])) { | |
| $objectParametersCount = count($this->data['components']['schemas'][$actionName . 'Object']['properties']); | |
| } else { | |
| $objectParametersCount = 0; | |
| } | |
| $properties = Arr::get($this->data, "components.schemas.{$actionName}Object.properties", []); | |
| $objectParametersCount = count($properties); |
Comment on lines
+1003
to
+1004
| if (empty($documentation['components']['schemas'][$definition])) { | ||
| $documentation['components']['schemas'][$definition] = $additionalDocumentation['components']['schemas'][$definition]; |
There was a problem hiding this comment.
Suggested change
| if (empty($documentation['components']['schemas'][$definition])) { | |
| $documentation['components']['schemas'][$definition] = $additionalDocumentation['components']['schemas'][$definition]; | |
| Arr::add($documentation, "components.schemas.{$definition}, $additionalDocumentation['components']['schemas'][$definition]); |
| { | ||
| $allowedContentType = false; | ||
|
|
||
| $types = [ |
There was a problem hiding this comment.
let's move it to the class const
|
|
||
| if (!$allowedContentType) { | ||
| throw new InvalidSwaggerSpecException( | ||
| "Operation '{$operationId}' has body parameters. Only one or the other is allowed." |
There was a problem hiding this comment.
Suggested change
| "Operation '{$operationId}' has body parameters. Only one or the other is allowed." | |
| "Operation '{$operationId}' has invalid content types: {$actualTypes}." |
|
|
@aizlee please make refactoring accordingly my comments as a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update OpenAPI version to 3.1.0