Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config logic update #103

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Config logic update #103

merged 6 commits into from
Sep 18, 2023

Conversation

Goodmain
Copy link
Contributor

Description

Implementation for the issue #84

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Goodmain Goodmain requested a review from DenTray September 16, 2023 22:24
Goodmain and others added 3 commits September 17, 2023 04:56
@Goodmain
chore: update deepsource configuration
5fb97ec
@Goodmain
style: fix code-style issue
fba2bb8
@deepsource-autofix
style: format code with PHP CS Fixer
9fb9019 
This commit fixes the style issues introduced in fba2bb8 according to the output
from PHP CS Fixer.

Details: #103
DenTray
DenTray requested changes Sep 18, 2023
View reviewed changes
.deepsource.toml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenTray DenTray merged commit c33ac24 into master Sep 18, 2023
@DenTray DenTray deleted the config-logic-update branch September 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenTray DenTray DenTray requested changes

Assignees

@DenTray DenTray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goodmain @DenTray