Add factory tests #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php
KonstantinLapkovsky
changed the base branch from
49-cover-entity-generator-with-tests
to
master
KonstantinLapkovsky
changed the base branch from
master
to
49-cover-entity-generator-with-tests
AZabolotnikov
changed the base branch from
49-cover-entity-generator-with-tests
to
master
# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php # tests/TestCase.php
AZabolotnikov
changed the base branch from
master
to
49-cover-entity-generator-with-tests
AZabolotnikov
changed the base branch from
49-cover-entity-generator-with-tests
to
master
DenTray
requested changes
Nov 26, 2024
src/Generators/FactoryGenerator.php
Outdated
| @@ -84,13 +94,9 @@ protected function generateToGenericClass(): string | |||
| return $createMessage; | |||
| } | |||
|
|
|||
| public function generate(): void | |||
| protected function allowedToCreateFactoryInSeparateClass(): bool | |||
There was a problem hiding this comment.
we can fully remove this logic as now package requires Laravel 11
DenTray
requested changes
Nov 27, 2024
|
|
||
| use Exception; | ||
|
|
||
| class FakerMethodNotFound extends Exception |
There was a problem hiding this comment.
Suggested change
| class FakerMethodNotFound extends Exception | |
| class FakerMethodNotFoundException extends Exception |
| { | ||
| use GeneratorMockTrait, MockTrait; | ||
|
|
||
| public function getFactoryGeneratorMockForExistingFactory(): void |
There was a problem hiding this comment.
Suggested change
| public function getFactoryGeneratorMockForExistingFactory(): void | |
| public function mockFactoryGenerator(...$functionCalls): void |
| public function getFactoryGeneratorMockForExistingFactory(): void | ||
| { | ||
| $this->mockClass(FactoryGenerator::class, [ | ||
| [ |
There was a problem hiding this comment.
please use special helpers for this as it using inside the controller generator test
| 'app' => [ | ||
| 'Models' => [ | ||
| 'Post.php' => file_get_contents(getcwd() . '/tests/Support/Factory/Post.php'), | ||
| 'User.php' => '<?php', |
There was a problem hiding this comment.
please use special helper for it as it implemented in ControllerGenerator mock trait
| $structure = [ | ||
| 'app' => [ | ||
| 'Models' => [ | ||
| 'Post.php' => file_get_contents(getcwd() . '/tests/Support/Factory/Post.php'), |
There was a problem hiding this comment.
is it necessary to use real content? or we can use any php content as in the model?
refs: #49
DenTray
approved these changes
Dec 2, 2024
# Conflicts: # src/Generators/FactoryGenerator.php
refs: #49
DenTray
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #49