Updated Laravel #89
Merged
Updated Laravel #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aizlee
commented
Aug 15, 2024
aizlee
commented
- updated Laravel to 11 version
- implemeted QueueEnum
- implemented ModelTestState
DenTray
requested changes
Aug 22, 2024
| @@ -83,25 +84,25 @@ public function logout(LogoutRequest $request): Response | |||
| return response('', Response::HTTP_NO_CONTENT)->withCookie($tokenCookie); | |||
| } | |||
|
|
|||
| public function forgotPassword(ForgotPasswordRequest $request, UserService $service): Response | |||
| public function forgotPassword(UserService $service, ForgotPasswordRequest $request): Response | |||
There was a problem hiding this comment.
please revert this change
app/Services/UserService.php
Outdated
Comment on lines
69
to
72
| ->update( | ||
| where:['id' => $user->id], | ||
| data: ['password' => Hash::make($password)] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ->update( | |
| where:['id' => $user->id], | |
| data: ['password' => Hash::make($password)] | |
| ) | |
| ->update($user->id, [ | |
| 'password' => Hash::make($password), | |
| ]) |
artisan
Outdated
| | | ||
| */ | ||
| // Register the Composer autoloader... | ||
| require __DIR__.'/vendor/autoload.php'; |
There was a problem hiding this comment.
Suggested change
| require __DIR__.'/vendor/autoload.php'; | |
| require __DIR__ . '/vendor/autoload.php'; |
artisan
Outdated
Comment on lines
12
to
13
| $status = (require_once __DIR__.'/bootstrap/app.php') | ||
| ->handleCommand(new ArgvInput); |
There was a problem hiding this comment.
Suggested change
| $status = (require_once __DIR__.'/bootstrap/app.php') | |
| ->handleCommand(new ArgvInput); | |
| $status = (require_once __DIR__ . '/bootstrap/app.php')->handleCommand(new ArgvInput); |
bootstrap/app.php
Outdated
Comment on lines
34
to
37
| web: __DIR__.'/../routes/web.php', | ||
| api: __DIR__.'/../routes/api.php', | ||
| commands: __DIR__.'/../routes/console.php', | ||
| channels: __DIR__.'/../routes/channels.php', |
There was a problem hiding this comment.
Suggested change
| web: __DIR__.'/../routes/web.php', | |
| api: __DIR__.'/../routes/api.php', | |
| commands: __DIR__.'/../routes/console.php', | |
| channels: __DIR__.'/../routes/channels.php', | |
| web: __DIR__ . '/../routes/web.php', | |
| api: __DIR__ . '/../routes/api.php', | |
| commands: __DIR__ . '/../routes/console.php', | |
| channels: __DIR__ . '/../routes/channels.php', |
tests/AuthTest.php
Outdated
Comment on lines
306
to
311
| $this->assertDatabaseMissing( | ||
| table: 'password_reset_tokens', | ||
| data: [ | ||
| 'email' => '[email protected]', | ||
| ], | ||
| ); |
There was a problem hiding this comment.
Suggested change
| $this->assertDatabaseMissing( | |
| table: 'password_reset_tokens', | |
| data: [ | |
| 'email' => '[email protected]', | |
| ], | |
| ); | |
| $this->assertDatabaseMissing('password_reset_tokens', [ | |
| 'email' => '[email protected]', | |
| ]); |
tests/UserTest.php
Outdated
|
|
||
| $response->assertOk(); | ||
|
|
||
| $this->assertEqualsFixture('user_created.json', $response->json()); | ||
|
|
||
| $this->assertDatabaseHas('users', $this->getJsonFixture('user_created_database.json')); | ||
| self::$userState->assertChangesEqualsFixture('user_created__users_state.json'); |
There was a problem hiding this comment.
Suggested change
| self::$userState->assertChangesEqualsFixture('user_created__users_state.json'); | |
| self::$userState->assertChangesEqualsFixture('user_created_users_state.json'); |
tests/UserTest.php
Outdated
|
|
||
| $response->assertNoContent(); | ||
|
|
||
| $this->assertDatabaseHas('users', $data); | ||
| self::$userState->assertChangesEqualsFixture('user_updated__users_state.json'); |
There was a problem hiding this comment.
Suggested change
| self::$userState->assertChangesEqualsFixture('user_updated__users_state.json'); | |
| self::$userState->assertChangesEqualsFixture('user_updated_users_state.json'); |
tests/UserTest.php
Outdated
|
|
||
| $response->assertNoContent(); | ||
|
|
||
| $this->assertDatabaseHas('users', $data); | ||
| self::$userState->assertChangesEqualsFixture('profile_updated__users_state.json'); |
There was a problem hiding this comment.
Suggested change
| self::$userState->assertChangesEqualsFixture('profile_updated__users_state.json'); | |
| self::$userState->assertChangesEqualsFixture('profile_updated_users_state.json'); |
tests/UserTest.php
Outdated
| $this->assertDatabaseMissing('users', [ | ||
| 'id' => 2, | ||
| ]); | ||
| self::$userState->assertChangesEqualsFixture('user_deleted__users_state.json'); |
There was a problem hiding this comment.
Suggested change
| self::$userState->assertChangesEqualsFixture('user_deleted__users_state.json'); | |
| self::$userState->assertChangesEqualsFixture('user_deleted_users_state.json'); |
DenTray
reviewed
Aug 23, 2024
…-empty-project into update-laravel-structure
DenTray
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.