Merge pull request #97 from RonasIT/dpankratov/refactoring

chore: remove useless code
RonasIT · Oct 29, 2024 · e324968 · e324968
2 parents 41dbb05 + 9b1f717
commit e324968
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 40 deletions.
diff --git a/app/Http/Middleware/RedirectIfAuthenticated.php b/app/Http/Middleware/RedirectIfAuthenticated.php
@@ -2,7 +2,6 @@
 
 namespace App\Http\Middleware;
 
-use App\Providers\RouteServiceProvider;
 use Closure;
 use Illuminate\Support\Facades\Auth;
 
@@ -11,18 +10,10 @@
  */
 class RedirectIfAuthenticated
 {
-    /**
-     * Handle an incoming request.
-     *
-     * @param  \Illuminate\Http\Request  $request
-     * @param  \Closure  $next
-     * @param  string|null  $guard
-     * @return mixed
-     */
     public function handle($request, Closure $next, $guard = null)
     {
         if (Auth::guard($guard)->check()) {
-            return redirect(RouteServiceProvider::HOME);
+            return redirect('/status');
         }
 
         return $next($request);

diff --git a/app/Http/Requests/Users/DeleteProfileRequest.php b/app/Http/Requests/Users/DeleteProfileRequest.php
@@ -8,6 +8,6 @@ class DeleteProfileRequest extends Request
 {
     public function authorize(): bool
     {
-        return $this->user()->isUser();
+        return !$this->user()->isAdmin();
     }
 }
diff --git a/app/Http/Resources/User/UserResource.php b/app/Http/Resources/User/UserResource.php
@@ -3,15 +3,9 @@
 namespace App\Http\Resources\User;
 
 use App\Http\Resources\BaseJsonResource;
-use Illuminate\Http\Response;
 
 class UserResource extends BaseJsonResource
 {
-    public function withResponse($request, $response): void
-    {
-        $response->setStatusCode(Response::HTTP_OK);
-    }
-
     public function toArray($request): array
     {
         return [

diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
@@ -10,11 +10,6 @@
 
 class AppServiceProvider extends ServiceProvider
 {
-    /**
-     * Bootstrap any application services.
-     *
-     * @return void
-     */
     public function boot(): void
     {
         /**
@@ -67,11 +62,6 @@ public function boot(): void
         RouteFacade::macro('version', fn (VersionEnum $version) => RouteFacade::prefix('v' . $version->value));
     }
 
-    /**
-     * Register any application services.
-     *
-     * @return void
-     */
     public function register()
     {
     }

diff --git a/composer.json b/composer.json
@@ -20,7 +20,7 @@
     "php-open-source-saver/jwt-auth": "^2.7",
     "psr/simple-cache": "^3.0",
     "ronasit/laravel-helpers": "^3.0.0-beta",
-    "ronasit/laravel-swagger": "^3.0.1-beta",
+    "ronasit/laravel-swagger": "^3.0.2",
     "spatie/laravel-google-cloud-storage": "^2.3",
     "spatie/laravel-ignition": "^2.8",
     "symfony/http-client": "^7.1.3",

diff --git a/composer.lock b/composer.lock
diff --git a/database/seeders/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php
@@ -6,7 +6,7 @@
 
 class DatabaseSeeder extends Seeder
 {
-    public function run()
+    public function run(): void
     {
         $this->call(UserSeeder::class);
     }

diff --git a/database/seeders/MediaSeeder.php b/database/seeders/MediaSeeder.php
diff --git a/database/seeders/UserSeeder.php b/database/seeders/UserSeeder.php
@@ -8,7 +8,7 @@
 
 class UserSeeder extends Seeder
 {
-    public function run()
+    public function run(): void
     {
         factory(User::class)->create([
             'role_id' => Role::USER,

diff --git a/tests/UserTest.php b/tests/UserTest.php
@@ -35,7 +35,7 @@ public function testCreate()
 
         $response = $this->actingAs(self::$admin)->json('post', '/users', $data);
 
-        $response->assertOk();
+        $response->assertCreated();
 
         $this->assertEqualsFixture('user_created.json', $response->json());