BUG: adding rocket radius parameter to rail buttons class #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…://github.com/RocketPy-Team/RocketPy into enh/environment-class-major-refactor-may-2024
…r-refactor-may-2024 ENH: Environment class major refactor may 2024
…ts (no break changes)
…s' of https://github.com/RocketPy-Team/RocketPy into bug/adding_rocket_radius_parameter_to_rail_buttons_class
rocket_radius attribute added to RailButtons Class
Running black to format files.
…lass in fixture_aerosurfaces.py file)
…s' of https://github.com/RocketPy-Team/RocketPy into bug/adding_rocket_radius_parameter_to_rail_buttons_class
… the tests (no break changes)" This reverts commit 49043db.
This reverts commit 77a70ad.
rocket_radius attribute added to RailButtons Class
Running black to format files.
… the tests (no break changes)" This reverts commit 49043db.
This reverts commit 77a70ad.
rocket_radius attribute added to RailButtons Class
Running black to format files.
… the tests (no break changes)" This reverts commit 49043db.
This reverts commit 77a70ad.
…s' of https://github.com/RocketPy-Team/RocketPy into bug/adding_rocket_radius_parameter_to_rail_buttons_class
juliomachad0
deleted the
bug/adding_rocket_radius_parameter_to_rail_buttons_class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCurrent behavior
Issue 606 resolution.
The RailButtons class did not have the rocket_radius parameter, which led to some errors when the user used the class in the same way as other aerosurfaces. The set_rail_buttons method had to be used. This is not technically an error, but I see it as a difficulty in the sense that there is a class that deviates from the usage pattern of other classes.
New behavior
I updated the RailButtons class by adding the rocket_radius parameter, to avoid the simulation failing if the user uses the class as they used the others. I also modified some tests to consider the new parameter.
Breaking change